search

wilas / vbkick

Tool for building and maintaining VirtualBox VMs described as a code in a single definition file.
Other
8 stars 5 forks source link

Multi-OS downloader support #3

Closed alanpearce closed 10 years ago

alanpearce commented 10 years ago

wget isn't installed by default on FreeBSD or Mac OSX, so downloading fails. vbkick should be able to switch between downloaders depending upon the OS and what's available. OSX ships with curl and FreeBSD ships with fetch.

wilas commented 10 years ago

wget isn't installed by default on Linux as well (minimal installation), so downloading may fails as well, but I would prefer to have one downloader and make it as required dependencies for vbkick. I would like to keep code as simple as possible. The question is curl vs wget. I think curl is much more portable (available for Linux, OSX, FreeBSD). It may be a good idea to add dependencies check in "Main" section.

alanpearce commented 10 years ago

That works too. I agree that curl is more widely-available by default, so it would be a good choice for a downloader. Perhaps it should be checked for at the start of the script and exit with a message if it's not found, to make it clearer in the unlikely event that it's not available?

wilas commented 10 years ago

Yes check is good idea, but for all dependencies.

wilas commented 10 years ago

Do you want work on this issue or do you want me to do this ?

alanpearce commented 10 years ago

Sure, I'll go for it. :)