[Chore] Increase test coverage

[malparty]

Issue

Automated tests do not cover the core business logic (CSV upload, scraping).

Expected

While 100% test coverage is not required for this code challenge, all critical paths of the application should be unit-tested (and, ideally, UI-tested). So the following should be covered:

• CSV parsing
• Keyword creation
• Keyword scraping
• Keyword listing

[!Note] There is a bit of a challenge to implement tests for a service that generates HTTP requests. Hence, it is an expected part of the submission for us to assess your skills in writing challenging tests.

[wildan3105]

Thanks for this comment. For the following flows:

• CSV parsing
• Keyword creation
• Keyword scraping
• Keyword listing

Do you expect me to cover integration test (backend to call frontend)? Or frontend and backend could be done separately?

[malparty]

💡 As a lot of effort was already provided on the project, you do not need to handle any of the issues I just posted in the code. Your "text" responses are good for us to complete the assessment :)

But if that were a real project, our testing strategy would be like:

• put most of the effort into the unit tests (identify a class that has a well-defined scope) and cover all its possible cases (happy path but also error/exceptions/etc...). This class can use sub-classes which, most of the time won't need dedicated tests as the existing tests bring us enough confidence to the validity of the feature.
• have at least the "happy path" covered with a UI test (e.g. Cypress or Playwright). This way, we have the confidence that a user can perform the main flow of the application (and that all parts of the system connect together). In the context of this project, the minimum would be a flow similar to that: "Uploading a valid file, asserting the list of keywords and the details of one of the keywords".

[wildan3105]

Understood. Thank you for your thorough insight and understanding. I acknowledge that the testing strategy I employed may not have aligned with best practices, which may have impacted the confidence level during development. Your feedback has shed light on areas for improvement, and I genuinely appreciate the opportunity to learn and grow from this experience. Moving forward, I'll strive to implement more comprehensive testing strategies (iteratively during development) to ensure the robustness of future projects.