search

wildan3105 / google-scraper

Google scraper
https://google-scraper-web-7922a635d04a.herokuapp.com/
0 stars 1 forks source link

[Question] Tests decisions #39

Open malparty opened 5 months ago

malparty commented 5 months ago

When opening the GitHub project, I was very happy to see GitHub actions running tests for both the backend and frontend apps.

However, I was surprised to see the areas chosen to be covered by tests. Could you share more about why the tests have been implemented onto these specific areas: toast, notFound, healthCheck, and LogoutButton?

wildan3105 commented 5 months ago

Hey, thanks for the comments.

To be perfectly honest with you, I only have less than 12 hours to create all of those tests (since I was focusing on the app's functionalities, deployment, and (manual) regression test). Hence the decision was to create setup test (for backend -> healthcheck) and several easy-to-test components for frontend. If I had more time, I would definitely cover the essential and critical app flows like the one you've been creating issues for.

So in conclusion, I am happy to take the next few days to cover those areas. Let me know if you need clarification.

malparty commented 5 months ago

As mentioned in the other issue, you don't need to handle more code changes at this stage.

Thanks for your insights :pray:

wildan3105 commented 5 months ago

Very well, noted on that. Thanks a lot for your insight.