Source code hint - Githubissues

wildanSawaludin / flot

Automatically exported from code.google.com/p/flot

MIT License

0 stars 0 forks source link

Source code hint #746

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

I've analysed the code of Flot and noticed, that the "fmt" variable in the 
formatter() function isn't declared locally which makes it a global variable.. 
This issue is not very important but may be worth fixing for the sake of code 
organization :)

Original issue reported on code.google.com by szymon.b...@gmail.com on 29 Aug 2012 at 9:42

GoogleCodeExporter commented 9 years ago

Thanks very much for reporting this.  We had one similar report recently, but I 
was pretty certain there were other cases still lurking in there.

Original comment by dnsch...@gmail.com on 7 Sep 2012 at 9:31

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

May I suggest you use "use strict" on flot files? Newer browsers will give an 
error and stop execution (instead of failing silently) if they find things like 
this in the code, older browsers will just ignore it.

http://ejohn.org/blog/ecmascript-5-strict-mode-json-and-more/

Original comment by hoff...@gmail.com on 17 Oct 2012 at 8:53