Closed schmrlng closed 7 years ago
Actually, it seems that FLANN only depends on HDF5 for its own tests. So with the exception of unsafe_wrap
being undefined on 0.4, this seems to pass.
Since https://github.com/KristofferC/NearestNeighbors.jl lists julia 0.5
as a minimum requirement (and since 0.6 is right around the corner) I feel okay about dropping 0.4 and using unsafe_wrap
to implement getindex
instead of introducing a Compat.jl dependency. But I could go either way.
Bump
Hi Art,
Do you have any thoughts on these changes? If this package is no longer essential to your work I'd be happy to help maintain it in the future.
Thanks, Ed
Addresses https://github.com/wildart/FLANN.jl/issues/13; the source build may be finicky (particularly regarding the hdf5 build dependency) so at this point opening this PR is mostly just to see what travis thinks.