search

wildart / FLANN.jl

A Julia wrapper for Fast Library for Approximate Nearest Neighbors (FLANN)
Other
16 stars 14 forks source link

Force source build to ensure libflann 1.9.1 and add incremental construction methods #14

Closed schmrlng closed 7 years ago

schmrlng commented 7 years ago

Addresses https://github.com/wildart/FLANN.jl/issues/13; the source build may be finicky (particularly regarding the hdf5 build dependency) so at this point opening this PR is mostly just to see what travis thinks.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+26.6%) to 98.095% when pulling a8b06a9bfd19f179f3c341c5c096bcb66da2f1c8 on schmrlng:master into 15e257f61108a918b5a2e5c65f6b8380d3a056a9 on wildart:master.

schmrlng commented 7 years ago

Actually, it seems that FLANN only depends on HDF5 for its own tests. So with the exception of unsafe_wrap being undefined on 0.4, this seems to pass.

Since https://github.com/KristofferC/NearestNeighbors.jl lists julia 0.5 as a minimum requirement (and since 0.6 is right around the corner) I feel okay about dropping 0.4 and using unsafe_wrap to implement getindex instead of introducing a Compat.jl dependency. But I could go either way.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+26.6%) to 98.095% when pulling 40dae7368712de1d89cef24590627286557dc020 on schmrlng:master into 15e257f61108a918b5a2e5c65f6b8380d3a056a9 on wildart:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+26.6%) to 98.095% when pulling 40dae7368712de1d89cef24590627286557dc020 on schmrlng:master into 15e257f61108a918b5a2e5c65f6b8380d3a056a9 on wildart:master.

schmrlng commented 7 years ago

Bump

coveralls commented 7 years ago

Coverage Status

Coverage increased (+26.7%) to 98.276% when pulling c0fb219113142bd127d0f44493492ae3b1afb1b9 on schmrlng:master into 15e257f61108a918b5a2e5c65f6b8380d3a056a9 on wildart:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+26.7%) to 98.276% when pulling c0fb219113142bd127d0f44493492ae3b1afb1b9 on schmrlng:master into 15e257f61108a918b5a2e5c65f6b8380d3a056a9 on wildart:master.

schmrlng commented 7 years ago

Hi Art,

Do you have any thoughts on these changes? If this package is no longer essential to your work I'd be happy to help maintain it in the future.

Thanks, Ed