Closed schmrlng closed 5 years ago
LGTM. As soon as I create necessary tags. I'll merge it.
Great, thanks. I'm also going to push a commit here shortly that loosens a lot of the Matrix
/Vector
type restrictions to AbstracMatrix
/AbstractVector
so that, e.g., ReshapedArray
s/ReinterpretArray
s produced by reinterpret
ing Vector
s of SVector
s will also work. Please let me know if you'd instead prefer that change in a separate PR for discussion.
Bump, I think this is good to go -- thanks!
Revisiting this I think attobot now only works for tagging packages on julia 0.6 and earlier (which we may still want to do to tag the current state of this repo as v0.2.0).
After this PR is merged I think that we can just follow the instructions here to tag and release a 1.0-compatible version: https://github.com/JuliaRegistries/Registrator.jl. Theoretically, after merging this PR, to release a new version (I've put 1.0.0 in the Project.toml included in this PR; let me know if you'd prefer a different number) all you'll have to do is install Registrator and comment "@JuliaRegistrator register()" on the PR merge commit.
@JuliaRegistrator register()
Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.
Mostly just find/replace stuff; I didn't think carefully about whether any of the logic should be updated to better fit julia 1.0 features.
This PR will only work for julia 0.7+. To maintain 0.6 compatibility, I propose that a release be tagged for the current state of this repo (e.g., v0.2.0), and then another release be tagged after this PR is accepted/merged (e.g., v1.0.0).