wildart / FLANN.jl

A Julia wrapper for Fast Library for Approximate Nearest Neighbors (FLANN)
Other
16 stars 14 forks source link

Julia 1.0 compatibility, dropping 0.6 #18

Closed schmrlng closed 5 years ago

schmrlng commented 6 years ago

Mostly just find/replace stuff; I didn't think carefully about whether any of the logic should be updated to better fit julia 1.0 features.

This PR will only work for julia 0.7+. To maintain 0.6 compatibility, I propose that a release be tagged for the current state of this repo (e.g., v0.2.0), and then another release be tagged after this PR is accepted/merged (e.g., v1.0.0).

wildart commented 5 years ago

LGTM. As soon as I create necessary tags. I'll merge it.

schmrlng commented 5 years ago

Great, thanks. I'm also going to push a commit here shortly that loosens a lot of the Matrix/Vector type restrictions to AbstracMatrix/AbstractVector so that, e.g., ReshapedArrays/ReinterpretArrays produced by reinterpreting Vectors of SVectors will also work. Please let me know if you'd instead prefer that change in a separate PR for discussion.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.1%) to 98.507% when pulling f361e8d041b6f4031e2eae44e19bb5b692a99457 on schmrlng:0.7 into 08c41f4dc7eab1c1d5ffe9ebe75df3d33bd8c537 on wildart:master.

schmrlng commented 5 years ago

Bump, I think this is good to go -- thanks!

schmrlng commented 5 years ago

Revisiting this I think attobot now only works for tagging packages on julia 0.6 and earlier (which we may still want to do to tag the current state of this repo as v0.2.0).

After this PR is merged I think that we can just follow the instructions here to tag and release a 1.0-compatible version: https://github.com/JuliaRegistries/Registrator.jl. Theoretically, after merging this PR, to release a new version (I've put 1.0.0 in the Project.toml included in this PR; let me know if you'd prefer a different number) all you'll have to do is install Registrator and comment "@JuliaRegistrator register()" on the PR merge commit.

wildart commented 5 years ago

@JuliaRegistrator register()

JuliaRegistrator commented 5 years ago

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.