wildcat-finance / v2-protocol

Other
1 stars 0 forks source link

Bug/Behaviour To Address: Sanctioned Lender In Timelocked Market #29

Closed laurenceday closed 1 week ago

laurenceday commented 2 months ago

Dillon Kellar, [07/08/2024 23:18] just thought of something (don't need to reply now just don't want to forget) - what if the borrower has a wd time limit but someone gets sanctioned and forced into wd

Laurence E. Day, [07/08/2024 23:18] hm

Dillon Kellar, [07/08/2024 23:18] atm it'd revert

Laurence E. Day, [07/08/2024 23:20] i think it's worth flagging as something that could happen but i can't really think of a way to subvert the wd limit without opening up a path out that's probably too wobbly

Laurence E. Day, [07/08/2024 23:20] plus code-size

Laurence E. Day, [07/08/2024 23:21] man speaking of there was something else i wanted to flag as a 'this is interesting' but it's slipping out my mind again

Dillon Kellar, [07/08/2024 23:21] I'm sure you'll remember right as you're falling asleep lol

Laurence E. Day, [07/08/2024 23:21] naturally

Laurence E. Day, [07/08/2024 23:22] okay write that down somewhere too so that we know to flag it, that's a Medium/High that's begging to be pinged in an audit

Dillon Kellar, [07/08/2024 23:22] true

Laurence E. Day, [07/08/2024 23:23] they still wouldn't be able to withdraw the funds once the market becake open-term at the end, it'd just mean that the borrower should terminate at the end - everyone else would be able to get out their amount and leave the sanctioned amount frozen in there - interest is a PITA but it is what it is i think

andfletcher commented 2 months ago

We should make sure that the borrower is aware of this.

andfletcher commented 2 months ago

We need to make sure that the hooks contract can overwrite if a market is terminated.

laurenceday commented 1 week ago

We don't want to give sanctioned lenders priority or open up a path 'through' the timelock [this looks preferential even though it's urgent]

The solution here would just be to reduce the expiry so that the market immediately converts to a perpetual and force them out thereafter: this would be awkward for the borrower, but we think it's unlikely to arise in practice