search

wilddom / memrise2anki-extension

An extension for Anki 2 that downloads and converts a course from Memrise into an Anki deck.
ISC License
159 stars 22 forks source link

Fixed login procedure #94

Closed realmayus closed 2 years ago

realmayus commented 3 years ago

Memrise made significant changes to its login procedure, rendering this plugin broken. I completely revamped the sign in code so that it works again. The download code still works as of now.

wilddom commented 3 years ago

Thank you! I do have two questions though:

  1. Did you really have problems with the old login method or did you implement this for the future? Because actually the old login method still seems to work for me. But either way it's definitely great to have a working implementation.

  2. Are you sure that the requests module is part of the Anki distribution? I got some complaints from Windows users in the past about missing modules.

realmayus commented 3 years ago
  1. Yeah, someone asked me if I could look into it and after deleting the cookies of the extension I was able to confirm that the login system doesn't work anymore
  2. I'll have to check this, if it's not part of Anki I can see if I get it to work with the same packages you were using 👍
realmayus commented 3 years ago

Hmm, I just checked again and it looks like the https://app.memrise.com/login/ endpoint works again. I'll have to confirm this though. Before I fixed the plugin it didn't work, for some reason. Maybe they implemented a redirect

wilddom commented 3 years ago

Okay, the old login endpoint doesn't seem to be stable: #95

Digital-Coder commented 3 years ago

@realmayus I tried your commit for possible solution ,but I still got error mentioned here #102. But it seems its only failing on large downloads like 5000+ notes

wilddom commented 2 years ago

@realmayus I tried your commit for possible solution ,but I still got error mentioned here #102. But it seems its only failing on large downloads like 5000+ notes

The mentioned issue is not related to the login procedure.