wildfish / django-gdpr-assist

Tools to help manage user data in the age of GDPR
Other
174 stars 16 forks source link

Performance: flip conditional order during model anonymisation in force-mode #45

Closed ghost closed 2 years ago

ghost commented 3 years ago

This avoids evaluation and invocation of the is_anonymised method on the model to be anonymised. The method involves a database query to perform an existence check.

Relates to #44 (performance optimizations).

codecov-commenter commented 3 years ago

Codecov Report

Merging #45 (1bf303c) into develop (8ec2a5b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #45   +/-   ##
========================================
  Coverage    97.72%   97.72%           
========================================
  Files           20       20           
  Lines          659      659           
========================================
  Hits           644      644           
  Misses          15       15           
Impacted Files Coverage Δ
gdpr_assist/models.py 99.37% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47f84f1...1bf303c. Read the comment docs.