search

wildfly-extras / prospero

Prospero is a tool combining Galleon feature packs and wildfly-channels to provision and update Wildfly server.
Apache License 2.0
9 stars 24 forks source link

Update the channel add command to accept channel as well as manifest #668

Closed parsharma closed 3 months ago

parsharma commented 4 months ago

Fixes: https://github.com/wildfly-extras/prospero/issues/206

I've created a separate branch instead of using the old one. It would be helpful if you could review it @TomasHofman & @spyrkob. There are some remaining tasks, such as fixing test cases and completing the code. I want to ensure that I'm on the right track and not missing anything important.

parsharma commented 4 months ago

One build ubuntu-latest-pmd is failing but it is not failing in local. Can we rerun this build if possible?

TomasHofman commented 4 months ago

Did you try locally the same command the job is running?

mvn pmd:aggregate-pmd-check -DskipTests
TomasHofman commented 4 months ago

pmd is sort of like checkstyle, so it looks like legitimate failure...

parsharma commented 4 months ago

@TomasHofman yes now it is failing after running PMD command. Error is not clear. Where should I check?

TomasHofman commented 4 months ago

What does the prospero/target/pmd.xml contain? (Edited the path)

spyrkob commented 4 months ago

just FYI the gitlab action prints the summary of PMD check in a "Display report" step after running the tests, you can see the report there

parsharma commented 4 months ago

@spyrkob PR is ready for review.