wildfly-extras / wildfly-graphql-feature-pack

5 stars 6 forks source link

fix #111: update wildfly-plugin and configure for dev mode in quickstart #145

Closed t1 closed 1 year ago

t1 commented 1 year ago

also fixed some pom issues.

Note that I have some problems with the TypesafeGraphQLClientTestCase (even without any changes). It fails to start the server, because the server can't open the admin port 9990.

I also have issues with the Galleon plugin. When I run mvn galleon:provision, it complains about missing parameters featurePacks, installDir, as they are named feature-packs and install-dir.

jmartisk commented 1 year ago

Note that I have some problems with the TypesafeGraphQLClientTestCase (even without any changes). It fails to start the server, because the server can't open the admin port 9990.

I'm not seeing this problem when running with your branch

I also have issues with the Galleon plugin. When I run mvn galleon:provision, it complains about missing parameters featurePacks, installDir, as they are named feature-packs and install-dir.

I think you want to run mvn wildfly:provision instead. We are using the Galleon plugin for provisioning an instance in target/wildfly for testing purposes, during the test-compile phase (see https://github.com/wildfly-extras/wildfly-graphql-feature-pack/blob/a8296207f5a8cd4f262d38441db2b5f9852b8cbb/quickstart/pom.xml#L171) and if you execute mvn galleon:provision manually, it won't take into account the configuration from there. If you run wildfly:provision, you will get a provisioned server in target/server that uses the wildfly-maven-plugin config you're providing in this PR

jmartisk commented 1 year ago

Awesome, thanks a lot!