Closed jfdenise closed 9 months ago
@jmartisk , in order to integrate this feature-pack and layer into WildFly GLow.
Thanks @jfdenise this is awesome! I see there are some conflicts, could you rebase it, please? I will most likely then upgrade to SmallRye GraphQL 2.5.0 and make a release, do you have a deadline when you need it?
@jmartisk , I just rebased. We have flexibility to add the feature-pack to the registry. As soon as you have released the feature-pack I will be able to include it in https://github.com/wildfly/wildfly-galleon-feature-packs/tree/release for WildFly 30 version. BTW, I plan to look at porting the provisioning based on hard coded layers in your tests to be based on Glow discovery (as we have done in https://github.com/wildfly/wildfly/pull/17153).
@jmartisk , porting the tests to WildFly Glow went just fine. Let me know if you want it included in this PR: https://github.com/wildfly-extras/wildfly-graphql-feature-pack/commit/95101ba6dd1de3727d7b717818e612467231f717
@jmartisk , porting the tests to WildFly Glow went just fine. Let me know if you want it included in this PR: 95101ba
Yes please
Thanks! I'll let you know when I make the next release
Integrate this feature-pack with WildFly Glow tooling
Galleon layer metadata rule added to the Galleon layer: Any class contained in deployment annotated with org.eclipse.microprofile.graphql.* are making the layer microprofile-graphql to be provisioned.
In order to have this feature-pack integrated in the WildFly 30.0.0.Final Galleon feature-packs registry: https://github.com/wildfly/wildfly-galleon-feature-packs/tree/release we would need a new release of this feature-pack once this PR is merged.