search

wildfly-extras / wildfly-jar-maven-plugin

WildFly Bootable JAR
https://docs.wildfly.org/bootablejar/
Apache License 2.0
57 stars 40 forks source link

misconfigured layer doesn't fail app deployment. #255

Closed soul2zimate closed 3 years ago

soul2zimate commented 3 years ago

Version: 6.0.0.Alpha1

When I misconfigure a layer for my app, the deployment is successful without error, but the app is not functioning properly.

e.g. https://github.com/wildfly-extras/wildfly-jar-maven-plugin/tree/master/examples/jaxrs, update layer jaxrs to jsf

-                        <layer>jaxrs</layer>
+                        <layer>jsf</layer>

I see the deployment is successful (which is a surprise to me). I was expecting a deployment failure, or at least error in terminal. Is there a good reason behind this behavior ? The endpoint at http://localhost:8080/hello is not available.

jfdenise commented 3 years ago

@soul2zimate , I would say that it is a correct WildFly behavior, if you start the server without the jaxrs subsystem, the deployment endpoint will be not recognized as a JAXRS resource but the deployment will get deployed. @jamezp can confirm.

jamezp commented 3 years ago

Yes, it will deploy fine as there is nothing available to reject it. If the jaxrs subsystem is not present the deployment will just not be processed. There are no other processors that will be looking for Jakarta RESTful Web Services annotations.

soul2zimate commented 3 years ago

@jfdenise @jamezp Thank you both for the explanation, I am closing this as it's expected behavior.