wildfly-extras / wildfly-jar-maven-plugin

WildFly Bootable JAR
https://docs.wildfly.org/bootablejar/
Apache License 2.0
56 stars 40 forks source link

Adding logic to re-escape backslashes for CLI session properties file values #303

Closed fabiobrz closed 1 year ago

fabiobrz commented 2 years ago

In the context of CLI script execution, this is to re-escape backslashes once they have been loaded from the properties file.

The current implementation is a bit wild swince it just handles all the backslash occurrences, since it seems to me the issue is a general one. A more specific implementation is could be proposed to handle just values that match the windows path regex.

Feel free to let me know what you think @jfdenise, CC @yersan

Fixes #164

jfdenise commented 2 years ago

I am not sure we should handle this case. This syntax has been present since the start of Bootable JAR, CLI expects '\' to be escaped. So c:\x\y\z should be c:\x\y\z. Inside a properties file, this means c:\\x\\y\\z On Windows you can use forward slash, so c:/x/y/z would work.

jamezp commented 2 years ago

I agree with @jfdenise here.

fabiobrz commented 1 year ago

Closing the PR as per the feedback received in #164