search

wildfly-security / wildfly-openssl

Generic OpenSSL bindings for Java
Apache License 2.0
81 stars 72 forks source link

WFSSL-71 Do not use javax.security.cert.X509Certificate #101

Closed tristantarrant closed 3 years ago

tristantarrant commented 3 years ago

https://issues.jboss..org/browse/WFSSL-71

fjuma commented 3 years ago

https://github.com/wildfly-security/wildfly-openssl/pull/102 fixed the CI failures.

@tristantarrant Whenever you get a chance, if you could rebase this PR that would be great. The CI runs here don't seem to be picking up the latest changes for some reason. Thanks.

tristantarrant commented 3 years ago

rebased and repushed

fjuma commented 3 years ago

Thanks @tristantarrant!

@darranl This is ready for a second review. It looks like the macOS CI job is having trouble completing. We're not seeing this on other PRs. If you're able to, it might be good to try running this with your mac.

darranl commented 3 years ago

@fjuma I will try again tomorrow but it looks like master also hangs for me at the same location.

darranl commented 3 years ago

@fjuma FYI this is the logging I am seeing so far for the test that subsequently hangs:

https://gist.github.com/darranl/384be9283336ef07537fe2e3814494fa

I am not sure at the moment what options I have to add more logging if we need some more detail.

fjuma commented 3 years ago

@darranl So you're able to reproduce with master, not just with Tristan's PR? I just kicked off CI again here and it passed this time so must be something intermittent. Looking at the log from the gist, it looks fairly similar to the output from a successful run. Are you able to get a thread dump when the hang occurs?

darranl commented 3 years ago

@fjuma I have added a thread dump I attempted to the gist but it is a bit corrupted as it wrote to STDOUT, I will try if i can run that test in isolation and see if I can attach my debugger.

darranl commented 3 years ago

After being able to easily reproduce the MacOS error here the build is now completing for me without error. I am going to go ahead and merge the PRs and tag - if MacOS continues to play up it is not related to the recent changes.