search

wildfly-security / wildfly-openssl

Generic OpenSSL bindings for Java
Apache License 2.0
81 stars 72 forks source link

[WFSSL-65] Remove broken hasOp checks #98

Closed fjuma closed 3 years ago

fjuma commented 3 years ago

(Note: We should merge #96 and #97 before this one so we can trigger CI for this PR)

Remove broken hasOp checks for SSL_OP_NO_COMPRESSION, SSL_OP_NO_TICKET, and SSL_OP_CIPHER_SERVER_PREFERENCE since these ops have been present since before OpenSSL 1.0.1, which is the minimum required OpenSSL library version for WildFly OpenSSL.

This fix ensures that SSL_OP_NO_TICKET will always be set which fixes an issue a user ran into when using the WildFly OpenSSL provider with Jetty.

More details and discussions with Stuart can be found here: https://issues.redhat.com/browse/WFSSL-65

fjuma commented 3 years ago

Since this PR was created before the GitHub workflow for triggering CI was merged, I'm going to temporarily close it and then re-open it to trigger CI. It doesn't look like I can manually trigger it for a PR that was already open.