wildfly / galleon

Galleon Provisioning Tool
https://docs.wildfly.org/galleon/
Apache License 2.0
26 stars 30 forks source link

[GAL-290] MavenChannel.resolve should validate any build specified in… #268

Open bstansberry opened 4 years ago

bstansberry commented 4 years ago

… the FPL against the builds provided by the channel

https://issues.jboss.org/browse/GAL-290

This goes beyond the specific issue in that it should catch other cases where the specified build does not match what the channel provides (frequency or version range.)

This isn't a particularly elegant solution, but it seemed like adding an overloaded resolve method to MavenRepoManager to pass in the channel's various constraints would end up with an impl that does much the same kind of thing.

@aloubyansky or @jfdenise if you have any suggestions for how to test this please let me know. I added tests for GAL-280 that involve specifying a particular build but they must not be exercising the GAL-290 call path.