[GAL-334] Apply options even when plan is empty

wildfly / galleon

Galleon Provisioning Tool

https://docs.wildfly.org/galleon/

Apache License 2.0

26 stars 30 forks source link

[GAL-334] Apply options even when plan is empty #306

Closed spyrkob closed 2 years ago

spyrkob commented 2 years ago

Issue: https://issues.redhat.com/browse/GAL-334

jfdenise commented 2 years ago

@spyrkob , I think that this change is possibly not needed. One could check if the plan.isEmpty and not do an update. That is what Galleon CLI is doing: https://github.com/wildfly/galleon/blob/main/cli/src/main/java/org/jboss/galleon/cli/cmd/maingrp/UpdateCommand.java#L133 WDYT?

spyrkob commented 2 years ago

Yeah, I don't think it's needed, but the way ProvisionManager.apply works currently can be surprising. Maybe if the plan is empty ProvisionManager.apply should do nothing or throw an exception? Either way I'm happy to close this PR if you want to.

jfdenise commented 2 years ago

@spyrkob +1 to close it.