search

wildfly / wildfly-charts

Helm Charts for WildFly
https://docs.wildfly.org/wildfly-charts/
Apache License 2.0
3 stars 14 forks source link

Adding support to create an ingress entry #114

Closed ehsavoie closed 1 year ago

ehsavoie commented 1 year ago

Maybe I should disable ingress if route is enabled

ehsavoie commented 1 year ago

we can exclude ingress if route is enabled. Adding TLS is a bit complex as it requires a secret to provide the certificates: https://kubernetes.io/fr/docs/concepts/services-networking/ingress/#tls maybe for a future evolution ?

jmesnil commented 1 year ago

Adding TLS is a bit complex as it requires a secret to provide the certificates:

All we need to do is be able to pass the name of the secret, right? Creating the secret is out of scope of this Helm Chart.

ehsavoie commented 1 year ago

Updated with TLS and classname

ehsavoie commented 1 year ago

@jmesnil all remarjks should be resolved

ehsavoie commented 1 year ago

@jmesnil yes no problem I'll do that tomorrow

jmesnil commented 1 year ago

@ehsavoie FIY, I'm working on adding automated testing for this chart and using the ingress to try it (https://github.com/wildfly/wildfly-charts/compare/main...jmesnil:wildfly-charts:ehsavoie-issue_52)

jmesnil commented 1 year ago

@ehsavoie thanks, I'll merge this PR. This change is substantial enough to bump the version of wildfly-common lib chart but I'll do that in a separate PR