wildfly / wildfly-charts

Helm Charts for WildFly
https://docs.wildfly.org/wildfly-charts/
Apache License 2.0
3 stars 14 forks source link

Make the `build` step of the Helm Chart conditional on OpenShift resources #129

Open jmesnil opened 1 year ago

jmesnil commented 1 year ago

Is your feature request related to a problem? Please describe.

By default, the Helm chart creates resources to build an application image from a Git repo using OpenShift S2I and BuildConfig resources. If an user does not want to build their image, they have to:

A user that wants to deploy on Kubernetes must manually do that. However, the Helm chart could be made smarter and handle this use case too.

If the cluster does not have the BuildConfig capability, it should not create any resources relate to building from S2I. There would no longer be a need for the user to manually disable it. If that's the case, then the image.name field becomes required and the installation must fail if it is not set.

The configuration matrix would become:

On OpenShift

on Kubernetes

An user that wants to deploy a WildFly application on Kubernetes could use the simple value file:

image:
  name: my-app:latest

instead of the existing:

image:
  name: my-app:latest
build:
  enabled: false
deploy:
  route:
    enabled: false

(deploy.route.enabled is taking care of in #114 )