wildfly / wildfly-charts

Helm Charts for WildFly
https://docs.wildfly.org/wildfly-charts/
Apache License 2.0
3 stars 14 forks source link

Support new `GALLEON_DIR` and `GALLEON_PROVISION_FEATURE_PACKS` when using S2I. #16

Closed jmesnil closed 3 years ago

jmesnil commented 3 years ago

Is your feature request related to a problem? Please describe.

With https://issues.redhat.com/browse/CLOUD-3928, the user can specify a directory containing Galleon provisioning.xml as well as additional feature packs to provision when the application image is built.

To be consistent with the existing usage of galleonLayers, we will add 2 new fields to the build.s2i section.

Additional Galleon Feature packs

build:
  s2i:
    featurePacks: "org.example:foo-feature-pack:1.0,org.foo:my-other-feature-pack:5.0" `

or

build:
  s2i:
    featurePacks:
      - org.example:foo-feature-pack:1.0
      - org.foo:my-other-feature-pack:5.0

Custom Galleon Directory

Additional context

Implementation wise, in the BuildConfig for the build-artifacts:

jmesnil commented 3 years ago

Work to support these env vars in WildFly S2I images is described in https://github.com/wildfly/wildfly-proposals/pull/379 and done in https://github.com/wildfly/wildfly-s2i/pull/151 & https://github.com/wildfly/wildfly-s2i/pull/151