Add support for configuring kubernetes startup probe - Githubissues

wildfly / wildfly-charts

Helm Charts for WildFly

https://docs.wildfly.org/wildfly-charts/

Apache License 2.0

3 stars 14 forks source link

Add support for configuring kubernetes startup probe #32

Closed jmesnil closed 3 years ago

jmesnil commented 3 years ago

Is your feature request related to a problem? Please describe.

Kubernetes define a specific startup probe for applications that are slow to start: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes

We should provide a way to define such a probe from the Helm Chart.

This would add a deploy.startupProbe whose content will be a YAML configuration of the startup probe as defined in https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes

jmesnil commented 3 years ago

This feature would follow up what we did for readiness and liveness probes:

Add templating code to include a startupProbe if deploy.startupProbe is defined (similar to https://github.com/wildfly/wildfly-charts/blob/98e86bb0dd24d7c75131df6d764b9644eeb1a4b5/charts/wildfly-common/templates/_deployment.yaml#L61-L64)
Provide a default value in https://github.com/wildfly/wildfly-charts/blob/98e86bb0dd24d7c75131df6d764b9644eeb1a4b5/charts/wildfly/values.yaml#L27 (similar to readinessProbe) with maybe a higher failureThreshold: 18 so that the app has 3 minutes (18 * 10 = 180s) to startup.
Add doc in https://github.com/wildfly/wildfly-charts/blob/main/charts/wildfly/README.md (similar to deploy.readinessProbe)
Add schema validation in https://github.com/wildfly/wildfly-charts/blob/98e86bb0dd24d7c75131df6d764b9644eeb1a4b5/charts/wildfly/values.schema.json#L509 (but we don't provide the full validation schema for k8s probes)

yersan commented 3 years ago

This is superseded by https://github.com/wildfly/wildfly-charts/issues/37