search

wildfly / wildfly-charts

Helm Charts for WildFly
https://docs.wildfly.org/wildfly-charts/
Apache License 2.0
3 stars 14 forks source link

A helm chart new release that modifies the build config does not start a new build #56

Open yersan opened 2 years ago

yersan commented 2 years ago

Describe the bug Releasing a new Helm Chart version that contains a change in the build section does not automatically trigger a new build.

To Reproduce Steps to reproduce the behavior:

Deploy an application using Helm Chart and then modify the list of Galleon layers.

Expected behavior If I'm not doing something wrong, I would expect a new build execution, to build my application with the new desired list of galleon layers.

Component Versions(please complete the following information):

oc version
Client Version: 4.8.4
Server Version: 4.9.15
Kubernetes Version: v1.22.3+e790d7f

Additional context The OpenShift documentation contains the following note about this:

"Configuration change triggers currently only work when creating a new BuildConfig. In a future release, configuration change triggers will also be able to launch a build whenever a BuildConfig is updated."

So, although not intuitively, this behavior could be the expected one, in that case, we could use this issue as a kind of documentation. The workaround is to kick off the build manually:

oc start-build bc/<helm-release>-build-artifacts

jmesnil commented 2 years ago

Thanks for reporting this issue.

It seems to me that this is not a bug in our Helm Chart but just the way OpenShift works at the moment and this will eventually be changed in a future release.

I agree with you that this is not intuitive and we should definitely add a note about in the https://github.com/wildfly/wildfly-charts/blob/main/charts/wildfly/templates/NOTES.txt that is displayed to the user after helm install and helm upgrade commands