search

wildfly / wildfly-charts

Helm Charts for WildFly
https://docs.wildfly.org/wildfly-charts/
Apache License 2.0
3 stars 14 forks source link

kubeVersion does not allow to install on complex version of Kubernetes. #61

Closed jmesnil closed 2 years ago

jmesnil commented 2 years ago

Describe the bug

As reported by https://github.com/wildfly/wildfly-s2i/issues/324, installing on OKD 4.9 fails.

To Reproduce Steps to reproduce the behavior:

helm install jsf-ejb-jpa-app -f https://raw.githubusercontent.com/wildfly/wildfly-s2i/main/examples/jsf-ejb-jpa/helm.yaml wildfly/wildfly
Error: INSTALLATION FAILED: chart requires kubeVersion: >= 1.19.0 which is incompatible with Kubernetes v1.22.1-1839+b93fd35dd03051-dirty

Expected behavior

The Helm chart should be installed properly on such complex kubernetes versions such as v1.22.1-1839+b93fd35dd03051-dirty.

Component Versions:

oc version
Client Version: 4.10.0-0.okd-2022-03-07-131213
Server Version: 4.9.0-0.okd-2022-02-12-140851
Kubernetes Version: v1.22.1-1839+b93fd35dd03051-dirty

kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v0.23.0", GitCommit:"f93da17", GitTreeState:"clean", BuildDate:"2022-02-15T22:14:58Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"22+", GitVersion:"v1.22.1-1839+b93fd35dd03051-dirty", GitCommit:"b93fd35dd030519c24dd02f8bc2a7f873d2928cd", GitTreeState:"dirty", BuildDate:"2022-02-11T06:14:59Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (0.23) and server (1.22) exceeds the supported minor version skew of +/-1

Additional context

This is a common issue with the way Helm handles the kubeVersion field: https://github.com/helm/helm/issues/9371. The fix is to make the kubeVersion more inclusive by changing it from

kubeVersion: ">= 1.19.0"

to

kubeVersion: ">= 1.19.0-0"
bdlink commented 2 years ago

This fixed the issue (tried on OKD 4.9 and OKD 4.10) Thanks, Bruce