GALLEON_PROVISION_DEFAULT_FAT_SERVER is useless

wildfly / wildfly-charts

Helm Charts for WildFly

https://docs.wildfly.org/wildfly-charts/

Apache License 2.0

3 stars 14 forks source link

GALLEON_PROVISION_DEFAULT_FAT_SERVER is useless #94

Closed jfdenise closed 2 years ago

jfdenise commented 2 years ago

Setting this env variable is useless with WildFly s2i V2 and shouldn't be added by Helm Charts.

jmesnil commented 2 years ago

@jfdenise isn't that still useful if the Helm Chart is using S2I environment variables to set up the feature packs and layers?

jmesnil commented 2 years ago

should I keep it only if .build.s2i.galleonLayers is defined?

jfdenise commented 2 years ago

It is no more used. used to be needed when the default server was a "thin" server that we were not able to copy over the runtime image. mainly used with Openshift templates. Yo ucan safely remove it in all cases.