search

wildfly / wildfly-charts

Helm Charts for WildFly
https://docs.wildfly.org/wildfly-charts/
Apache License 2.0
3 stars 14 forks source link

[#93] Add the ability to skip building the application image #97

Closed jmesnil closed 2 years ago

jmesnil commented 2 years ago

If build.s2i.buildApplication is set to false, the resources to create the applicaition image are not generated. In that case, the builder-artifacts image will take over the name of the Helm release (as it is the only produced image).

Deployment of the builder image can still happen and needs to be explicitely disabled with deploy.enabled set to false if needs be.

This fixes #93

Signed-off-by: Jeff Mesnil jmesnil@redhat.com

jmesnil commented 2 years ago

@jfdenise, could you please review?

As you suggested, if the application image is not built, the builder image will take the name of the release. Iow, if the Helm configuration looks like:

build:
  uri: https://github.com/wildfly/wildfly-s2i
  contextDir: examples/web-clustering
  s2i:
   buildApplicationImage: false
deploy:
  enabled: false

And the Helm release is created with helm install web-clustering-builder -f ...., the name of the builder image will be web-clustering-builder.

jfdenise commented 2 years ago

@jmesnil , perfect. This naming will fit the builder use-case.