search

wildfly / wildfly-github-bot

GitHub bot for WildFly project.
Apache License 2.0
3 stars 13 forks source link

Run the application on Reopened #119

Closed petrberan closed 1 year ago

petrberan commented 1 year ago

Although it's an edge case when it comes to WFLY, I think the checks should be also performed once the PR is reopened. Even though the check should be valid from once the PR is closed as it's not changed, the config could change in the meantime, requiring the checks to be performed again.

Perhaps even on ready_for_review?

Thoughts @xstefank ?

xstefank commented 1 year ago

yes on reopen, no on labels

petrberan commented 1 year ago

What labels?

petrberan commented 1 year ago

Discussed offline, ready_for_review should be checked as well. I'll take the issue and wait for the #118 to be merged as this issue will fail 2 tests - as tested locally