search

wildfly / wildfly-github-bot

GitHub bot for WildFly project.
Apache License 2.0
3 stars 13 forks source link

We need to reevaluate how loggers are created #175

Closed The-Huginn closed 12 months ago

The-Huginn commented 12 months ago

Once #167 is merged, we should rethink how our custom logger is instantiated, as currently it is in static manner and such, the PR #167 will not work as expected with @Inject WildFlyConfig, as it will always be null (injection in static context), thus the condition for nullability is required.

The-Huginn commented 12 months ago

After offline discussion we have decided to prepend dry run message only to specific remote calls, thus it will not be responsibility in PullRequestLogger but individual log calls.