wildfly / wildfly-glow

Galleon Layers Output from War: Automatic discover of WildFly provisioning information from an application.
Apache License 2.0
7 stars 5 forks source link

Provisioning to OpenShift fails when using Microprofile GraphQL layer #72

Closed t1 closed 1 month ago

t1 commented 2 months ago

But when I try to provision my demo app that provides a Microprofile GraphQL service, the provisioning to OpenShift fails with this error message:

ERROR: Failure executing: POST at: xxx/imagestreams. Message: ImageStream.image.openshift.io "wildfly-server-xxx" is invalid: metadata.labels: Invalid value: "org.wildfly.glow.feature-pack.wildfly-microprofile-graphql-feature-pack": name part must be no more than 63 characters. Received status: Status(apiVersion=v1, code=422, details=StatusDetails(causes=[StatusCause(field=metadata.labels, message=Invalid value: "org.wildfly.glow.feature-pack.wildfly-microprofile-graphql-feature-pack": name part must be no more than 63 characters, reason=FieldValueInvalid, additionalProperties={})], group=image.openshift.io, kind=ImageStream, name=wildfly-server-xxx, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, message=ImageStream.image.openshift.io "wildfly-server-xxx" is invalid: metadata.labels: Invalid value: "org.wildfly.glow.feature-pack.wildfly-microprofile-graphql-feature-pack": name part must be no more than 63 characters, metadata=ListMeta(_continue=null, remainingItemCount=null, resourceVersion=null, selfLink=null, additionalProperties={}), reason=Invalid, status=Failure, additionalProperties={}).

org.wildfly.glow.feature-pack.wildfly-microprofile-graphql-feature-pack are 71 characters, but the limit seems to be 63, which seems to be an arbitrary and odd limitation to me.

t1 commented 2 months ago

Maybe getting rid of the -feature-pack suffix would help, but the real cause (in my eyes) is that limitation.

jfdenise commented 1 month ago

@t1 thank-you for your report! I am looking it into it.

jfdenise commented 1 month ago

@t1 , the 1.0.5.Final version contains the fix: https://github.com/wildfly/wildfly-glow/releases/tag/1.0.5.Final Thanks again for your report!