search

wildfly / wildfly-plugin-tools

A group of tools for interacting/managing with a WildFly container
Apache License 2.0
0 stars 2 forks source link

Do not read deployment content into memory #40

Closed jamezp closed 3 months ago

jamezp commented 3 months ago

Reported on WFARQ-178)

When starting Arquillian tests, the WildFly Arquillian part reads the whole EAR into a byte-array before sending it to the server for deployment. And even after the deployment was done, this memory seems to stay blocked.

We do not use a minimal deployment with just the test-relevant classes, but the full EAR just with the tests added in, to have a more production-like environment for the tests.

This means the whole big EAR is read into a byte-array and then regularly busts the max-heap.

It would be nice if this could be done instead in some streamed way instead of reading the full deployment to the heap of the test worker process.

jamezp commented 3 months ago

The best option for this will be making the Deployment implement AutoCloseable to cleanup resources when done. For compatibility purposes a shutdown hook will be added to delete files if they Deployment is not closed.