search

wildfly / wildfly-tck-runners

Test runners for executing various TCKs against a WildFly runtime
Apache License 2.0
1 stars 7 forks source link

Cleanup Core Profle TCK runner #58

Closed scottmarlow closed 1 year ago

scottmarlow commented 1 year ago

https://github.com/wildfly/wildfly-tck-runners/issues/57

scottmarlow commented 1 year ago

Are we ready to merge this PR or do we need more changes?

scottmarlow commented 1 year ago

@jamezp @bstansberry

Could we merge this change as It seems like this change helps avoid some Core Profile 10 failures.

Testing without this pr:

failures=[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.416 s <<< FAILURE! - in ee.jakarta.tck.ws.rs.jaxrs21.ee.sse.ssebroadcaster.JAXRSClientIT [ERROR] Tests run: 2654, Failures: 1, Errors: 0, Skipped: 59 [ERROR] Tests run: 4, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 9.286 s <<< FAILURE! - in ee.jakarta.tck.core.rest.jsonb.cdi.CustomJsonbSerializationIT [ERROR] Tests run: 13, Failures: 2, Errors: 1, Skipped: 0 errors=[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.133 s <<< FAILURE! - in ee.jakarta.tck.jsonp.signaturetest.jsonp.JSONPSigTest [ERROR] Tests run: 179, Failures: 0, Errors: 1, Skipped: 0 [ERROR] Tests run: 4, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 9.286 s <<< FAILURE! - in ee.jakarta.tck.core.rest.jsonb.cdi.CustomJsonbSerializationIT [ERROR] Tests run: 13, Failures: 2, Errors: 1, Skipped: 0

Testing with this pr:

At least one test failed! failures=[ERROR] Tests run: 4, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 10.072 s <<< FAILURE! - in ee.jakarta.tck.core.rest.jsonb.cdi.CustomJsonbSerializationIT [ERROR] Tests run: 13, Failures: 2, Errors: 1, Skipped: 0 errors=[ERROR] Tests run: 4, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 10.072 s <<< FAILURE! - in ee.jakarta.tck.core.rest.jsonb.cdi.CustomJsonbSerializationIT [ERROR] Tests run: 13, Failures: 2, Errors: 1, Skipped: 0

scottmarlow commented 1 year ago

We still need to understand why ee.jakarta.tck.core.rest.jsonb.cdi.CustomJsonbSerializationIT is failing but it is good to see the ee.jakarta.tck.jsonp.signaturetest.jsonp.JSONPSigTest passing with this pr.

bstansberry commented 1 year ago

Thanks @scottmarlow