wildhart / meteor.jobs

A simple job scheduler for Meteor.js
MIT License
18 stars 8 forks source link

Meteor 3.0 support #26

Open jamauro opened 8 months ago

jamauro commented 8 months ago

Hey @wildhart, any plans for an update for Meteor 3.0 now that it’s nearing a beta?

Would love to upgrade a project to Meteor 3.0 early next year.

Thanks again for making this package!

wildhart commented 8 months ago

Hi @jamauro thank you for your interest in this package. I'll try to get a Meteor 3 version published over the week or so.

Note to self: add a comment on this doc when done: https://forums.meteor.com/t/meteor-3-0-packages-compatibility/60985

wildhart commented 8 months ago

@jamauro I have a version which works with Meteor 2.8, but I'm strugging to get the 3.0 alpha releases to install. Feel free try it though:

mkdir packages
cd packages
git clone -b meteor_3.0_async https://github.com/wildhart/meteor.jobs.git
cd ..

Your project might pick up the new wildhart-jobs.d.ts type defintions from that file, if not copy it into a @types folder in your project root.

As with the migration from Mongo sync to async, you'll have to go through your job code and convert all references from the old ...method() to the new await ...methodAsync() methods. I've deliberately renamed all the methods which have become async so it's clear you need to await them...

Please test thoroughly...

JanMP commented 1 month ago

The dependency on mongo needs to be updated

While selecting package versions:
   error: Conflict: Constraint mongo@1.1.5 is not satisfied by mongo 2.0.0.
   Constraints on package "mongo":
   * mongo@2.0.0 <- top level
   * mongo@~2.0.0 <- top level
   * mongo@2.0.0-rc300.4 <- cultofcoders:redis-oplog 3.0.0-rc.1
   * mongo@1.16.1 || 2.0.0-rc300.0 <- alanning:roles 4.0.0-alpha.3 <- janmp:sdui 1.0.0
   * mongo@2.0.0 <- accounts-base 3.0.0
   * mongo@1.16.10 || 2.0.0-rc300.2 <- tunguska:reactive-aggregate 2.0.0
   * mongo@2.0.0-rc300.8 <- montiapm:agent 3.0.0-beta.5
   * mongo@1.1.24||2.0.0-alpha300.10 <- montiapm:meteorx 2.3.1 <- montiapm:agent 3.0.0-beta.5
   * mongo@1.1.5 <- wildhart:jobs 1.0.9
aboire commented 1 month ago

meteor 3 : you need to change the observe to observeAsync