Open walljcg opened 1 month ago
Here are the issues identified during research:
dict
is not supported by react-jsonschema-form. While we could represent it as an array of key-value pairs, our parser has to understand the key-value types, while dictionary values can be Any
. style_kws
is a good example where lonboard supports arguments of any types but we need to parse user input first to extract values of the correct type. My recommendation is to only support a subset of arguments which we specify the types, like what we did here. Happy to hear your thoughts: @walljcg @cisaacstern tuple
is not supported either, (used by Filter
). Any reason we didn't make it a pydantic data model?get_params_jsonschema
returns a dict of json schemas while react-jsonschema-form requires fields like properties
. Added those fields in the dictionary.patrol_workflow
filename
, view
, groupers
The fix can be found here #123
Responses to above points in https://github.com/wildlife-dynamics/ecoscope-workflows/pull/123#pullrequestreview-2216061317 (responded on the PR to combine that with my review there)
Created the following tasks based on our discussion
Hopefully this week I can get all patrol-workflow configuration correctly rendered (stretch goal). Then I'll work on key improvement for user experience.
Review all the task params within the patrols workflow and compare against the 'out-of-the-box' (shot-cn) json schema controls to see what we might need to customize ourselves versus what we get for free (e.g., floats, text, arrays, tuples, dicts, datetime, integers, )