Open atmorling opened 2 months ago
Also note:
Our notion of a "Basemap" is derived from Leafmap's basemaps
module, which is effectively a collection of common WMS/XYZ tileservers, where the "Basemap" is just the first tile layer added to the map. This is distinct from the deck.gl "Basemap" which is map client like MapLibre or OpenLayers used as a base for deck.gl to overlay on top of. For our purposes the Leafmap way of thinking makes more sense and this conflicts a little with Lonboard's implementation. I don't see any roadblocks for us right now, but this is something to pay attention to.
This looks good! Is this json spec based on anything specific or a combination of different things? A few points from my side: the order of the layers in the json should define their order when drawn on the map. We should also be able to handle multiple of everything, e.g., multiple gdfs, ee layers etc. I'd probably rename 'InitialViewState' to 'ViewState'. I don't love the 'basemap' naming convention because it's really just a tiled raster layer that happens to be at the bottom. I think let's just call it 'tiled_raster' and then we can also have 'tiled_vector' layer. We should look at supporting WFS services as well.
What about something like:
Such that the python would be:
gdf_layer
in this case is intended to represent point data. We could make it more explicit by replacinggdf_layer
withscatterplot_layer
, but the type can be inferred from the data supplied.@vis_params
or@values