search

wildlifetrusts / nextdoornature

https://team-wilder-proto.pages.dev/
2 stars 1 forks source link

Feat/309 search guides stories and actions #555

Closed katjam closed 1 year ago

katjam commented 1 year ago

Partial #309

Description

@geeksforsocialchange/developers

netlify[bot] commented 1 year ago

Deploy Preview for team-wilder-content ready!

Name Link
Latest commit 947e54d24d3040f40c222eaa57502b6bc2822f8d
Latest deploy log https://app.netlify.com/sites/team-wilder-content/deploys/6494d1655f1e3300087d7c3e
Deploy Preview https://deploy-preview-555--team-wilder-content.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

katjam commented 1 year ago

If I can't get this working for the morning - we should remove the search box before people start testing.

@r-ferrier can you check where it's at in the morning and liaise with @AutumnBarlow? I think the best solution is to take out the search box and let people test without it until it's working. That will cause the least confusion. I'll get it fixed over the weekend either way but I can't guarantee internet tomorrow.

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 947e54d
Status: ✅  Deploy successful!
Preview URL: https://8964f8ea.team-wilder-proto.pages.dev
Branch Preview URL: https://feat-309-search-guides-stori.team-wilder-proto.pages.dev

View logs

katjam commented 1 year ago

@r-ferrier I think I've fixed it enough to merge, but would be grateful for a sanity check. If you are happy, go ahead without me. I'll try to be online. Catching a bus at 09.30.

katjam commented 1 year ago

Great catch. Was there one more thing outstanding in the plan on #309 that needs converting to issue? I did have some problems with the web component causing app to freeze intermittently so am probably going to refactor into a port voluntarily.

On Fri, 23 Jun 2023, 09:25 Rosemary Ferrier, @.***> wrote:

Merged #555 https://github.com/geeksforsocialchange/teamwilder/pull/555 into main.

— Reply to this email directly, view it on GitHub https://github.com/geeksforsocialchange/teamwilder/pull/555#event-9615309283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGSH5GB3ZQX5HO3KXH4PCDXMVHIHANCNFSM6AAAAAAZQRXP5E . You are receiving this because you authored the thread.Message ID: @.*** com>

r-ferrier commented 1 year ago

The outstanding issue is that the search box is on every page.

I've been trying to get this button working but I think I'm going to have to leave it - I just can't for the life of me get a key listener to fire properly on the input - probably something to do with the search setup making use of the shadow dom, which is not something i've worked with before - I think I need someone with more front end experience to explain why!

I also got slight stuck because we had another bug which meant we were only ever looking at the results from the last search every time we reran the search. Have fixed this so will push as a separate fix and change the text & link to 'explore the hub' for now.

katjam commented 1 year ago

I think you are right. I may find time to move this weekend or just leave it be. Don't want to break right before launch.

On Fri, 23 Jun 2023, 11:23 Rosemary Ferrier, @.***> wrote:

The outstanding issue is that the search box is on every page.

I've been trying to get this button working but I think I'm going to have to leave it - I just can't for the life of me get a key listener to fire properly on the input - probably something to do with the search setup making use of the shadow dom, which is not something i've worked with before - I think I need someone with more front end experience to explain why!

I also got slight stuck because we had another bug which meant we were only ever looking at the results from the last search every time we reran the search. Have fixed this so will push as a separate fix and change the text & link to 'explore the hub' for now.

— Reply to this email directly, view it on GitHub https://github.com/geeksforsocialchange/teamwilder/pull/555#issuecomment-1604066900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGSH5CCODFPY7WWRGVS3YTXMVVDNANCNFSM6AAAAAAZQRXP5E . You are receiving this because you authored the thread.Message ID: @.***>