Tests for 2 days ago/from now fails

wildlyinaccurate / angular-relative-date

AngularJS filter to provide relative, human-readable dates.

69 stars 23 forks source link

Tests for 2 days ago/from now fails #33

Open OskarPersson opened 6 years ago

OskarPersson commented 6 years ago

I get a few failures when running the tests on my machines:

PhantomJS 2.1.1 (Mac OS X 0.0.0) Filter: relativeDate Has the correct response for each interval FAILED
    Expected 'yesterday' to equal '2 days ago'.
    test/spec/relative-date-filter.js:38:57
    Expected '3 days from now' to equal '2 days from now'.
    test/spec/relative-date-filter.js:61:57

I'm guessing this has something to do with my timezone (Sweden - CEST) and/or DST.

wildlyinaccurate commented 6 years ago

Aha, I forgot about this issue! I did have an open branch on the non-angular version of this module to fix this (wildlyinaccurate/tiny-relative-date#3) but I think it's just that the tests are wrong.

OskarPersson commented 6 years ago

I ran the tests from the PR of the non-angular module locally and those passes 👍