search

wildlyinaccurate / jekyll-responsive-image

An unopinionated Jekyll plugin for generating and using responsive images
MIT License
332 stars 48 forks source link

More permissive rmagick dep #87

Closed pedantic-git closed 4 years ago

pedantic-git commented 4 years ago

RMagick 2.x will no longer compile on Arch Linux because the libmagick6 is no longer compatible with it.

I've tested this plugin works in my use case at least with RMagic 4.x so this is a simple PR that just relaxes that dependency a little.

Let me know if you'd like me to test anything!

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f3103be702d1e8355a7b50944ed77c7079c5bc2c on fishpercolator:master into 5715734bde5af5fae64dd04e2d773c5708a7be36 on wildlyinaccurate:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f3103be702d1e8355a7b50944ed77c7079c5bc2c on fishpercolator:master into 5715734bde5af5fae64dd04e2d773c5708a7be36 on wildlyinaccurate:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f3103be702d1e8355a7b50944ed77c7079c5bc2c on fishpercolator:master into 5715734bde5af5fae64dd04e2d773c5708a7be36 on wildlyinaccurate:master.

wildlyinaccurate commented 4 years ago

Thanks for this! Do you know if newer versions of rmagick are still compatible with libmagick6? I'm not near a computer at the moment to test myself.

pedantic-git commented 4 years ago

@wildlyinaccurate Rmagick 4.0.0 is still only compatible with libmagick6, but this version works with the latest libmagick6 in Arch. The 4.1.0 release candidates are meant to be compatible with libmagick7 (I've not tried them) but if they're following semver then calling them 4.1.0 suggests they're backwards compatible with 4.0.0.

wildlyinaccurate commented 4 years ago

Sweet, sounds good to me. I'll do some quick testing before I merge, and if it all looks good I'll push a new version of the jekyll-responsive-image gem.

(Sorry for the slow reply - I've been on vacation)

pedantic-git commented 4 years ago

@wildlyinaccurate No problem! I've waited over 2 years for some PRs to be merged!

wildlyinaccurate commented 4 years ago

:ship: v1.5.4 of the gem includes this change