wildside96 / bst-player

Automatically exported from code.google.com/p/bst-player
0 stars 0 forks source link

Change default behavior for missing video codec metadata #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Valid FLV capable of being played does not have video codec meta data
2. When its played with bst-player the video will be black

What is the expected output? What do you see instead?
Black space is seen where video should be.  Sound is heard.

What version of the product are you using? On what operating system?
bst-player 1.0 on Windows 7-64 and Flash 10

Please provide any additional information below.

Since the movie is going to play anyway (sound is heard), mine as well
default to the player to determine if it should be shown or not rather than
make the decision in the application.  I built my own version of 1.0 that
releases this issue by modifying:

File: bst-flash-player\src\main\flex\com\bramosystems\oss\player\VideoEngine.as

Method: metadataHandler

Line: 121 (in version 1.0 tag)

Change:  Add "visible = true;" in default section of video codec. 

Original issue reported on code.google.com by sselik...@gmail.com on 8 Dec 2009 at 9:21

GoogleCodeExporter commented 9 years ago
Hello Scott,

Welcome to the project.

The statement was left out to prevent the black box from showing when playing 
MP4
formatted audio files for instance.  Guess we need another way or what do you 
think
about such behaviour?

Original comment by sbrah...@gmail.com on 9 Dec 2009 at 10:19

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
It seems unnecessary to make it invisible since the user can control the size.  
If
the user does not specify a size, then the application acts as if visible is 
set to
false.  Otherwise, if the user does specify a size then they intended there to 
be
video and we should acknowledge it.

I agree that a fix for missing codec information is not great, but there may be 
others
who receive video files with incomplete meta data.  Alternatively, we could had 
a
forceShowVideo override flag but it seems unneeded since the user can set the 
size.

Original comment by sselik...@gmail.com on 9 Dec 2009 at 2:56

GoogleCodeExporter commented 9 years ago
I quite agree with that.  If user specify a size then video should show.

Original comment by sbrah...@gmail.com on 9 Dec 2009 at 4:41

GoogleCodeExporter commented 9 years ago
Added support for unknown video codec in meta data and checked into trunk.

Original comment by sselik...@gmail.com on 10 Dec 2009 at 12:37