search

wildtruc / nvidia-prime-select

This a fork of FedoraPrime enhanced for all linux distributions
GNU General Public License v3.0
127 stars 14 forks source link

Zenity is a dependency, yet is not mentioned as a pre-requisite #7

Closed NucleaPeon closed 5 years ago

NucleaPeon commented 5 years ago

On gentoo (KDE), while running 'sudo make install':

mkdir -p /etc/nvidia-prime
install -Dm755 -t /usr/bin/ nvidia-prime-ui
install -Dm755 -t /usr/sbin/ nvidia-prime-select
install -Dm644 -t /etc/nvidia-prime/ xorg.nvidia.conf
install -Dm644 -t /etc/nvidia-prime/ xorg.intel.conf
install -Dm644 -t /etc/nvidia-prime/ library.conf
install -Dm644 -t /etc/nvidia-prime/ options.conf
install -Dm644 -t /etc/nvidia-prime/ report.sample
install -Dm644 -t /etc/nvidia-prime/ nvidia-prime.desktop
install -Dm644 -t /etc/nvidia-prime/ nvidia-session.desktop
install -Dm644 -t /usr/share/pixmaps/ nvidia-prime.png
install -Dm644 -t /usr/share/applications/ nvidia-prime-ui.desktop
install -Dm644 -t /usr/share/polkit-1/actions/ com.github.pkexec.nvidia-prime-select.policy
install -Dm644 -t /usr/share/polkit-1/actions/ com.github.pkexec.nvidia-prime-editor.policy
bash ./changelog.sh
./changelog.sh: line 6: --width=200: command not found
./changelog.sh: line 11: --width=520: command not found

Checking if zenity is installed and exiting with a message saying something like "zenity is required but not installed", or having a cli fallback, would be a nice feature. I had to dig into the changelog.sh file to understand what was going wrong.

Thanks

wildtruc commented 5 years ago

Apparently, you just have to install zenity with you default package manager. Zenity is required for the graphical interface and it is used by the changelog.sh to display script's last change and fix. Note that Zenity is so rarely not installed by default (I even didn't know it was still the case for some distro), I didn't think to mention it. I will fix.

wildtruc commented 5 years ago

Done.