wildyeast / sadiss

A socially aggregated distributed sound system.
GNU Affero General Public License v3.0
10 stars 2 forks source link

Find out if using WebSocket.WebSocket as a type is a good way to do things #113

Open matbind opened 7 months ago

matbind commented 7 months ago

In /server/types/ws/index.d.ts we extend WebSocketAlias with properties we need on the WebSocket type. This leads to at least one instance where we use WebSocket.WebSocket to satisfy the TS compiler. This comes from this github answer. Anwers further down in the same issue have other solutions which might be better. I don't really understand them though and have not yet taken the time trying to do so.

Find out if there is a better way to do this and if the current solution is any good at all or just a bandaid fix.