search

wildyeast / sadiss

A socially aggregated distributed sound system.
GNU Affero General Public License v3.0
10 stars 2 forks source link

Maximum polyphony setting #22

Closed KlienVo closed 2 years ago

KlienVo commented 2 years ago

the 'maximum polyphony' setting is visible when selecting a choir track on the performance page. (e.g. https://sadiss.net/api/performances/7)

Hence my question: Does the max. polyphony setting define max. polyphony for the entire performance or for individual tracks? For choir tracks it is not applicable, given there is only one partial per phone anyway. -> move setting to performance setting?

matbind commented 2 years ago

It does apply to the entire performance, but has no effect on choir tracks AFAIK.

What exactly do you mean by moving it to the performance setting? Have it defined on performance creation and than be unchangeable after? Or just have it somewhere else in the interface? If you mean the latter, we can certainly do this.

KlienVo commented 2 years ago

Right now the setting only becomes visible when one of the tracks is selected. Which lead me to believe the setting would be track-dependent.

I think it would be clearer if we put it somewhere else on the same page and adding text, explaining that the setting applies to the entire performance and will be ignored by all choir tracks.

wildyeast commented 2 years ago

Setting the polyphony limit applies to individual tracks, not performances. It has no effect in choir mode. To make this clearer, it would make sense to hide the polyphony checkbox and input field if the track is in choir mode.

wildyeast commented 2 years ago

Implemented