Closed KlienVo closed 1 year ago
It is now possible to download the QR code for the performance (.svg) and the QR codes for each partial of the track with the most partials (svgs in zip).
The current solution has limitations. If the track with the most partials has partials with indices 0, 1, 2, 3, 4
, those are the ones used when generating the QR codes. If another track has indices 0, 5
there will be issues, since 5
is not present in the QR codes. @KlienVo, can we guarantee that the indices of the partials of every track always start at 0 and increase by 1 for every partial? If yes, the current solution is good enough. If no, we have to do some more, shouldn't be too much of a problem though (we could e.g. ignore the indices from the partials in the input file and create our own indices starting a 0 when saving to the DB).
On PDF: Generating pdfs with QR codes and additional information should be easy to implement. Still, it would require quite some work, and I am not sure it is worth it right now. If you want, I can implement it. Otherwise please test and close this issue if everything works as expected, and we put PDF generation in a new issue as an enhancement.
Every choir track created with the 'midi2sdif' max patch will have partial indices starting from 0. Alos just added this naming requirement to the Wiki documentation of choir mode.
Dropdown menu to select download format for barcode
[x] ~pdf download (1 codes per page)~
[x] vector-graphics
[x] For multi QR code generation/download, only use voices of choir track with most voices, not track with most voices choir or non-choir
[x] ~If choir track in performance, don't allow download of performance QR code, as it makes no sense to have a QR code without partial ids~ This now has its own issue #41
[ ] When playing choir track with two voices, and QR codes generated for three voices, assign one of first two voices to third voice of second track