wildyeast / sadiss

A socially aggregated distributed sound system.
GNU Affero General Public License v3.0
10 stars 2 forks source link

QR Codes - format #8

Closed KlienVo closed 1 year ago

KlienVo commented 2 years ago

Dropdown menu to select download format for barcode

matbind commented 2 years ago

It is now possible to download the QR code for the performance (.svg) and the QR codes for each partial of the track with the most partials (svgs in zip).

The current solution has limitations. If the track with the most partials has partials with indices 0, 1, 2, 3, 4, those are the ones used when generating the QR codes. If another track has indices 0, 5 there will be issues, since 5 is not present in the QR codes. @KlienVo, can we guarantee that the indices of the partials of every track always start at 0 and increase by 1 for every partial? If yes, the current solution is good enough. If no, we have to do some more, shouldn't be too much of a problem though (we could e.g. ignore the indices from the partials in the input file and create our own indices starting a 0 when saving to the DB).

On PDF: Generating pdfs with QR codes and additional information should be easy to implement. Still, it would require quite some work, and I am not sure it is worth it right now. If you want, I can implement it. Otherwise please test and close this issue if everything works as expected, and we put PDF generation in a new issue as an enhancement.

KlienVo commented 2 years ago

Every choir track created with the 'midi2sdif' max patch will have partial indices starting from 0. Alos just added this naming requirement to the Wiki documentation of choir mode.