search

wiley / madgex-lazy-ads

Deliver synchronous ads asynchronously, without modifying the ad code. Also, conditionally load ads for responsive websites using a media query or the ad container's dimensions.
MIT License
656 stars 42 forks source link

Wrong package.json #10

Closed yoyurec closed 9 years ago

yoyurec commented 9 years ago

Can you add new field required by NPM: "main": "dist/lazyad-loader.js" ? https://github.com/substack/browserify-handbook#how-node_modules-works

jameswragg commented 9 years ago

Added, thanks.

yoyurec commented 9 years ago

FYI: your package not in NPM repository ((( but people can install it with npm install madgex/lazy-ads --save :sunglasses:

yoyurec commented 9 years ago

PS: npm WARN package.json lazyad-loader@1.1.7 No repository field. not "must to do", but some day you'll need to update it with more fields.

http://package-json-validator.com/

jameswragg commented 9 years ago

No it's not in NPM but is in bower. I've patched up the package.json now so that the validator you mentioned is a little happier! Thanks.

yoyurec commented 9 years ago

:+1: :100: