wileyyugioh / zotmoov

Zotero plugin to automatically move attachments and link them
GNU General Public License v3.0
467 stars 6 forks source link

.html attachments not renamed when "attach new file" #61

Open notuntoward opened 1 week ago

notuntoward commented 1 week ago

I have enabled zotmoov's setting to "automatically move/copy files when added", and I also have html in my list of "allowed files extensions." However, when I run "Zotmoov: Attach New File", the file is moved and attached as expected but neither the new attachment filename or title are renamed from metadata.

Should I expect this to happen?

wileyyugioh commented 1 week ago

Zotmoov uses Zotero's default renaming scheme under the hood, and it seems like it doesn't support html. Maybe you can try the fix here?

TW96 commented 1 week ago

Zotmoov uses Zotero's default renaming scheme under the hood, and it seems like it doesn't support html. Maybe you can try the fix here?

So does that mean there are effectively two levels of file type permissions when zotmoov moves/renames an attachment - one for which file types get moved (zotmoov's allowed list) and another for what file types get renamed (Zotero's list) ? So unless the lists are made the same, any particular file type might be moved but not renamed ?

BTW the Zotero hidden preference discussion you linked to does seem to work for getting HTML files renamed.

wileyyugioh commented 1 week ago

So does that mean there are effectively two levels of file type permissions when ZotMoov moves/renames an attachment - one for which file types get moved (ZotMoov's allowed list) and another for what file types get renamed (Zotero's list) ?

Yes basically. Importing any file uses the default Zotero renaming feature, but whether or not the file is later moved/copied is done by ZotMoov's settings. When you import a file using attach new file, ZotMoov does the same checks Zotero does to see whether or not the file should be renamed to ensure consistency.

You can think of it as a separation of responsibilities. Renaming files: Zotero. Moving/coping them: ZotMoov