wilfm / GnomeExtensionMaximusTwo

Removes the title bar on maximised windows. See: https://extensions.gnome.org/extension/844/maximus-two/
63 stars 27 forks source link

Gnome 3.16 support #21

Closed wilfm closed 8 years ago

wilfm commented 9 years ago

Gnome 3.16 has been released

Mainstream support is currently not quite available (except on Arch),a Ubuntu PPA's on the development version need to be used, & for Fedora you need the 22 Alpha (or possibly backports to older versions).

If you are using 3.16 and want, add 3.16 to the metadata.json file (similar to the method here) and place the extension's files in ~/.local/share/gnome-shell/extensions/maximus-two@wilfinitlike.gmail.com. I will submit a update at a future date after testing it and attempting to fix existing issues.

ronjouch commented 9 years ago

@wilfm 3.16 was pushed today to Arch. Patched my metadata.json and Maximus Two seemed happy. https://github.com/wilfm/GnomeExtensionMaximusTwo/issues/2 is still present, apart from that everything is fine like under 3.14 :)

KingYes commented 9 years ago

I just added this in my Arch, and I don't see that exts in Tweak tool.

ronjouch commented 9 years ago

@KingYes can you check (user-local) ~/.local/share/gnome-shell/extensions and (system-global) /usr/share/gnome-shell/extensions/ and check that the extension is in one of them ? In the extension folder, check metadata.json and ensure "shell-version" contains "3.16". Then restart the shell (Alt + F2, r) and relaunch Tweak Tool.

If still problematic, please post a new issue with as much detail as possible. This issue is about supporting 3.16; if you were hit by the issue you'd see the extension in Tweak Tool, but it would be greyed out.

KingYes commented 9 years ago

Hi ! After reboot and reboot I see this now. Thanks. :)

ikuraj commented 9 years ago

Can you update the extension on https://extensions.gnome.org/extension/844/maximus-two/?

mat-mo commented 9 years ago

I see in my journal:

gnome-session[704]: (gnome-shell:6393): Gjs-WARNING **: JS ERROR: TypeError: appMenu._label.setText is not a function gnome-session[704]: updateAppMenu@/home/matanya/.local/share/gnome-shell/extensions/maximus-two@wilfinitlike.gmail.com/app_menu.js:41

ikuraj commented 9 years ago

Extension seems to be working as usual, after modifying metadata.json

I see the error @mat-mo reported and I also see an additional one:

gnome-session[1445]: (gnome-shell:1511): Gjs-WARNING **: JS ERROR: TypeError: Shell.StageInputMode is undefined
gnome-session[1445]: onFocusChange@/home/ivcha/.local/share/gnome-shell/extensions/maximus-two@wilfinitlike.gmail.com/app_menu.js:74
sheldonh commented 9 years ago

Thanks, @ptpt. Your PR works perfectly on Fedora 22.

davidcortesortuno commented 8 years ago

I think it is not working for Gnome 3.16.2

wilfm commented 8 years ago

Should be fixed with https://github.com/wilfm/GnomeExtensionMaximusTwo/releases/tag/5

ronjouch commented 8 years ago

Hi @wilfm, thanks. Looks like v5 reuses code from PixelSaver, what should we expect with this? Specific areas needing testing?

wilfm commented 8 years ago

@ronjouch This extension is (currently, and in the past, and for quite a bit into the future) is almost entirely based on Pixel Saver, it started as I wanted to use the Window Buttons extension(s), which I then shared so others could use it. I think I will however add some features in (preferences, window menu, stuff) so it easy to use :) , and will have a go at fixing issues that affect both extensions.