search

wilfm / GnomeExtensionMaximusTwo

Removes the title bar on maximised windows. See: https://extensions.gnome.org/extension/844/maximus-two/
63 stars 27 forks source link

Replace window checking idle loop with a timeout #33

Open danielkza opened 8 years ago

danielkza commented 8 years ago

Also, make sure the onWindowAdded callback is only called once when the window is already properly added to the compositor. Keep the timeout running otherwise, instead of setting a new one up every time.

This seems to fix #32 for me, but needs more testing, and testing on GNOME versions other than 3.16.

Talv commented 8 years ago

Thanks for the fix. Can confirm that it indeed does fix mentioned issue. Tested on arch gnome shell 3.16.3.

ghost commented 8 years ago

Oops spoke too soon, upon restart MaximusTwo won't load as an extension.

danielkza commented 8 years ago

@xHN35RQ Any errors in the GNOME debug UI? (Alt-F2 -> lg)

ghost commented 8 years ago

@danielkza thank you for checking with me, I just tried it again and this time no errors. I had to edit gnome-shell version in metadata.json to get it working as I'm on 3.14. So far gnome-shell is hovering between 0% and 5% depending on usage, which is usual for me. So far so good! Thanks again!

wilfm commented 8 years ago

I'll be able to test this on 3.16 and 3.18 then should be able to merge it. Do you think this should be available for 3.14 as well?

ghost commented 8 years ago

I've had no issues with this branch so far.

wilfm commented 8 years ago

I have left this mess for far too long :( I will try and merge and fix stuff this evening or tomorrow...

zakkak commented 8 years ago

Tested on ArchLinux 64bit with Gnome 3.18 and everything looks fine, after about a full day of use.