[minecraft-spigot] Spigot Instances won't create properly

kiralabs commented 2 years ago

Environment

Installation type: pip
Python version: Python 3.10.4
Wilfred version: wilfred version v0.10.1/stable (commit cfa76bc)

Steps to Reproduce

Create a Minecraft Spigot Server, any version.

Expected Behavior

The server didn't create, only a config was dropped in the directory and attempting to start the server fails.

Observed Behavior

Starting the server fails with "💥 Error APIError 409 Client Error for http+docker://localhost/v1.41/containers/4be80f5db8566eb3a62b8bc5f144cac1339aaaad4b60009451e284011fac384a/logs?stderr=1&stdout=1&timestamps=0&follow=1&tail=200: Conflict ("can not get logs from container which is dead or marked for removal")"

minecraft-vanilla is working without any issues however.

vilhelmprytz commented 2 years ago

*** The version you have requested to build requires Java versions between [Java 17, Java 18], but you are using Java 8
*** Please rerun BuildTools using an appropriate Java version. For obvious reasons outdated MC versions do not support Java versions that did not exist at their release.
mv: can't rename 'spigot-*.jar': No such file or directory
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   105  100   105    0     0    300      0 --:--:-- --:--:-- --:--:--   300

This seems to be the reason it's failing. Will investigate, thanks for the report!

vilhelmprytz commented 2 years ago

This has now been fixed, it only took me a couple of commits :). Try wilfred images --refresh and creating a server with the image minecraft-spigot.

wilfred-dev / wilfred