@MatthewThe What do you think, should we add a check here to see which version is installed on the system and set the column name accordingly? I also suggest we put percolator in the installation requirements with the right version so that we know people are having the correct version installed. On the other hand, this is probably not that easy due to different operating systems?
Describe the bug
Percolator 3.06 expects a column "Proteins" instead of "Protein". This is a breaking change wrt. to oktoberfest.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
oktoberfest should work with percolator 3.06 System [please complete the following information]:
Additional context See these issues in the percolator repo: https://github.com/percolator/percolator/issues/329 https://github.com/percolator/percolator/issues/353
Here we need to change this line: https://github.com/wilhelm-lab/spectrum_fundamentals/blob/ad4edf5c74ae1ee0f0e47294a90fbcebaadb9455/spectrum_fundamentals/metrics/percolator.py#L290 which should be "Proteins" from now on.
@MatthewThe What do you think, should we add a check here to see which version is installed on the system and set the column name accordingly? I also suggest we put percolator in the installation requirements with the right version so that we know people are having the correct version installed. On the other hand, this is probably not that easy due to different operating systems?