search

wilhelmagren / gromp

Holistic Python implementation of the public Riot Games Developer API.
MIT License
6 stars 1 forks source link

Add static typing to classes and functions (#26) #27

Closed wilhelmagren closed 1 year ago

wilhelmagren commented 1 year ago

Some minor changes to functionality also:

wilhelmagren commented 1 year ago

Looks good, waiting for codecov report...

codecov[bot] commented 1 year ago

Codecov Report

Base: 83.89% // Head: 86.69% // Increases project coverage by +2.79% :tada:

Coverage data is based on head (70143b1) compared to base (b6f5df6). Patch coverage: 92.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ========================================== + Coverage 83.89% 86.69% +2.79% ========================================== Files 43 43 Lines 559 699 +140 ========================================== + Hits 469 606 +137 - Misses 90 93 +3 ``` | [Impacted Files](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren) | Coverage Δ | | |---|---|---| | [gromp/api/\_\_init\_\_.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvYXBpL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | | | [gromp/api/league/\_\_init\_\_.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvYXBpL2xlYWd1ZS9fX2luaXRfXy5weQ==) | `100.00% <ø> (ø)` | | | [gromp/endpoint/\_\_init\_\_.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvZW5kcG9pbnQvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | | | [gromp/handler/base.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvaGFuZGxlci9iYXNlLnB5) | `77.77% <66.66%> (-22.23%)` | :arrow_down: | | [gromp/api/league/Clashv1Api.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvYXBpL2xlYWd1ZS9DbGFzaHYxQXBpLnB5) | `70.00% <71.42%> (ø)` | | | [gromp/endpoint/base.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvZW5kcG9pbnQvYmFzZS5weQ==) | `70.00% <75.00%> (+0.30%)` | :arrow_up: | | [gromp/api/base.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvYXBpL2Jhc2UucHk=) | `56.52% <80.00%> (ø)` | | | [gromp/api/league/Championv3Api.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvYXBpL2xlYWd1ZS9DaGFtcGlvbnYzQXBpLnB5) | `85.71% <80.00%> (ø)` | | | [gromp/api/league/LolStatusv4Api.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvYXBpL2xlYWd1ZS9Mb2xTdGF0dXN2NEFwaS5weQ==) | `85.71% <80.00%> (ø)` | | | [gromp/api/league/ChampionMasteryv4Api.py](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren#diff-Z3JvbXAvYXBpL2xlYWd1ZS9DaGFtcGlvbk1hc3Rlcnl2NEFwaS5weQ==) | `90.00% <85.71%> (ø)` | | | ... and [26 more](https://codecov.io/gh/willeagren/gromp/pull/27?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Wilhelm+%C3%85gren)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.