search

wilk / microjob

A tiny wrapper for turning Node.js worker threads into easy-to-use routines for heavy CPU loads.
https://wilk.github.io/microjob/
MIT License
2.02k stars 47 forks source link

docs: add link to node terminate description #22

Closed larshp closed 6 years ago

larshp commented 6 years ago

docs: add link to node terminate description

Also, the section says "Graceful shutdown", I'd consider it to be forceful shutdown 🤷‍♂️

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 16

Totals Coverage Status
Change from base Build 11: 0.0%
Covered Lines: 84
Relevant Lines: 87
💛 - Coveralls
wilk commented 6 years ago

Thanks for this PR! Yes, I do agree: Forceful Shutdown sounds better 😄 Would you like to update this PR?

larshp commented 6 years ago

updated, changed to "Force shutdown", sounds better IMHO than my first suggestion

wilk commented 6 years ago

updated, changed to "Force shutdown", sounds better IMHO than my first suggestion

I'd like to stick to "Forceful Shutdown" instead of "Force Shutdown" (it sounds like an action instead of a title), what do you think?

larshp commented 6 years ago

updated

wilk commented 6 years ago

Thanks! 💪